Remove custom Accordion close button element #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Maintenance: - Limit divergence from USWDS, facilitating ongoing maintenance and reducing potential confusion introduced by enhancements exclusive to the login.gov Design System. Accessibility: - The button's behavior is duplicative with the toggle, where the additional tab stop may be excessive as repeated content. - Collapsing an accordion by the close button causes a focus loss ([SC 2.4.7](https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-visible.html), [SC 2.4.3](https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html)) - The relationship between the button and controlled content is not clearly indicated (e.g. [`aria-controls`](https://www.w3.org/TR/wai-aria-1.1/#aria-controls))
juliaelman
pushed a commit
that referenced
this pull request
Jul 16, 2021
* Remove custom Accordion close button element **Why**: Maintenance: - Limit divergence from USWDS, facilitating ongoing maintenance and reducing potential confusion introduced by enhancements exclusive to the login.gov Design System. Accessibility: - The button's behavior is duplicative with the toggle, where the additional tab stop may be excessive as repeated content. - Collapsing an accordion by the close button causes a focus loss ([SC 2.4.7](https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-visible.html), [SC 2.4.3](https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html)) - The relationship between the button and controlled content is not clearly indicated (e.g. [`aria-controls`](https://www.w3.org/TR/wai-aria-1.1/#aria-controls)) * Remove unused variable $icon-size * Restore border radius to accordion content bottom border * Clarify removal of JavaScript exported member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Maintenance:
Accessibility:
aria-controls)typeattribute, despite the fact that the button is not intended for form submission.